Skip to content

fix the Base.dataids method #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsajko merged 1 commit into from
Sep 18, 2025
Merged

fix the Base.dataids method #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/ZeroDimensionalArrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ mutable struct BoxConst{T} <: AbstractArray{T, 0}
end
end

const ZeroDimensionalArray = Union{
const ZeroDimensionalArrayCanNotMutateElement = Union{
ZeroDimArray,
Box,
BoxConst,
}

const ZeroDimensionalArray = Union{
ZeroDimensionalArrayCanNotMutateElement,
Box,
}

function type_to_constructor_function(::Type{T}) where {T <: ZeroDimensionalArray}
local ret
if T <: ZeroDimArray
Expand Down Expand Up @@ -158,8 +162,8 @@ end

# https://github.com/JuliaLang/julia/issues/51753
if isdefined(Base, :dataids) && hasmethod(Base.dataids, Tuple{Box{Float32}})
function Base.dataids(a::ZeroDimensionalArray)
Base.dataids(only(a))
Base.@nospecializeinfer function Base.dataids((@nospecialize a::ZeroDimensionalArrayCanNotMutateElement),)
()
end
end

Expand Down