Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 113 114 +1
=========================================
+ Hits 113 114 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It looks like codecov dropped to 0 in this commit b9790c5. Am I doing something wrong? |
|
I'm not convinced the See what I did in Enzyme: https://github.com/EnzymeAD/Enzyme.jl/blob/2cd186bee0195dc5eb3eebc6a599ce56676e4e0f/test/runtests.jl#L5-L6 and then passed it in https://github.com/EnzymeAD/Enzyme.jl/blob/2cd186bee0195dc5eb3eebc6a599ce56676e4e0f/test/runtests.jl#L72. |
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
|
Well, this is still not finding any tests? |
|
hmmm, lemme see if I can peek at what |
|
huh, is it typical for github CI to nest dirs like this? |
|
Yes, that's correct: |
|
Interesting, ok. The search continues |
|
ugggh found it. I just can't type. Should be |
cgarling
left a comment
There was a problem hiding this comment.
Looks good Ian, thanks for the work! Only couple minor suggestions
Co-authored-by: Chris Garling <chris.t.garling@gmail.com>
Co-authored-by: Chris Garling <chris.t.garling@gmail.com>
Co-authored-by: Chris Garling <chris.t.garling@gmail.com>
|
Awesome, should be in now, thanks Chris! |
Getting things spruced up a bit so Photometry.jl can depend on it.
Doc preview:https://juliaastro.org/BackgroundMeshes.jl/previews/PR19/
Closes: #14
To-do: