-
Notifications
You must be signed in to change notification settings - Fork 8
Added P92 model #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Added P92 model #29
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7f3bdb4
added P92 model
siddharthlal25 4aaace3
added tests
siddharthlal25 4c9ea45
minor fix
siddharthlal25 db5f19f
added bounds for input parameters
siddharthlal25 db0b306
added unitful tests
siddharthlal25 6eaa0aa
added plot
siddharthlal25 d047c1f
added more tests
siddharthlal25 664075f
added bibliography and docs
siddharthlal25 cf7e854
modified docs and added comments
siddharthlal25 9b822a8
Merge branch 'master' into p92
siddharthlal25 af0f6c6
minor change in tests
siddharthlal25 d67ce71
fix code style in plots.jl
siddharthlal25 3aa664c
Update src/fittable_laws.jl
siddharthlal25 d229b2c
fix docs
siddharthlal25 aba857b
Merge branch 'master' into p92
siddharthlal25 cf971b7
Merge branch 'master' into p92
abhro 1b6d056
Use `Base.@kwdef` for `P92`
abhro c7562d8
Update doctest output in fittable_laws.jl
abhro b8da82f
Move P92.bib to docs/src/assets/bibtex/
abhro cc8cb1f
Remove duplicate docs in color_laws.md
abhro 6fd4431
Use `lplot()` to dynamically generate plots for P92
abhro 6ce76e4
Merge branch 'master' into p92
abhro 95a536e
Update whitespace in markdown table
abhro 631f335
Merge branch 'master' into p92
abhro 71811e7
Update src/fittable_laws.jl
abhro dfd36a2
Update src/fittable_laws.jl
abhro de5b437
Update method signature in docstring for P92
abhro 90615f0
Apply suggestions from code review
abhro a93b178
Update src/fittable_laws.jl
abhro 30d848a
update docs with correct P92 FUV_lambda value
icweaver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| @ARTICLE{1992ApJ...395..130P, | ||
| author = {{Pei}, Yichuan C.}, | ||
| title = "{Interstellar Dust from the Milky Way to the Magellanic Clouds}", | ||
| journal = {\apj}, | ||
| keywords = {Cosmic Dust, Intergalactic Media, Interstellar Extinction, Interstellar Matter, Magellanic Clouds, Milky Way Galaxy, Chemical Evolution, Far Ultraviolet Radiation, Kramers-Kronig Formula, Astrophysics, GALAXIES: INTERGALACTIC MEDIUM, GALAXIES: INTERSTELLAR MATTER, GALAXIES: MAGELLANIC CLOUDS, ISM: DUST, EXTINCTION}, | ||
| year = 1992, | ||
| month = aug, | ||
| volume = {395}, | ||
| pages = {130}, | ||
| doi = {10.1086/171637}, | ||
| adsurl = {https://ui.adsabs.harvard.edu/abs/1992ApJ...395..130P}, | ||
| adsnote = {Provided by the SAO/NASA Astrophysics Data System} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ export redden, | |
| M14, | ||
| # Fittable laws | ||
| FM90, | ||
| P92, | ||
| # Mixture laws | ||
| G16, | ||
| G03_SMCBar, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.