This repository was archived by the owner on Mar 12, 2021. It is now read-only.
use Defer instead of atexit - #24
Open
adambrewster wants to merge 3 commits into
Open
Conversation
Contributor
|
Defer.jl sounds definitively interesting. I am slightly wary of adding a new dependencies. @kshyatt What do you think? |
Contributor
Author
|
That's a very reasonable objection, but Defer is pure julia and only about ~100 lines of code. The downside in this particular case is less than for some other packages that you might like to depend on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously proposed not closing the cublas handle in an atexit handler (#19). This PR is for the same reasons but proposes an alternate mechanism to see the handle is closed if and when desired by the user. It also partially addressed #15.