Add utility functions to traverse trees to find minimum, maximum node and the keys adjacent to a node #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s within the tree and within subtrees, and an abovebelow function that returns the nodes immediately above and below a given BinaryNode
eliascarv
reviewed
Feb 23, 2025
eliascarv
reviewed
Feb 23, 2025
…o accepts the key, functions like an advanced search now. fixed tests using @inferred Nothing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage ? 97.59%
=======================================
Files ? 3
Lines ? 166
Branches ? 0
=======================================
Hits ? 162
Misses ? 4
Partials ? 0 ☔ View full report in Codecov by Sentry. |
juliohm
reviewed
Feb 24, 2025
juliohm
reviewed
Feb 24, 2025
juliohm
reviewed
Feb 24, 2025
juliohm
reviewed
Feb 24, 2025
juliohm
reviewed
Feb 24, 2025
juliohm
reviewed
Feb 24, 2025
There was a problem hiding this comment.
The PR looks great. Just a few suggestions and updates to comments in source code.
@eliascarv please feel free to give the final review and merge when you feel it is ready.
eliascarv
reviewed
Feb 24, 2025
eliascarv
reviewed
Feb 24, 2025
…Type to the full type (using their subset rule). Let me know if there's a better alternative
eliascarv
reviewed
Feb 25, 2025
…an allow supertype of result
eliascarv
reviewed
Feb 26, 2025
eliascarv
reviewed
Feb 26, 2025
eliascarv
reviewed
Feb 26, 2025
souma4
force-pushed
the
JRC_min_max_abovebelow
branch
from
bb70a51 to
1e9a292
Compare
|
You can now give your final review @juliohm. |
eliascarv
approved these changes
Feb 26, 2025
juliohm
approved these changes
Feb 26, 2025
|
@eliascarv feel free to merge and release a patch. If you can add me as collaborator in this repository as well, that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussions in #12 and #1168. This adds utility functions to compute the minimum and maximum values within subtrees (or a whole tree), and a function to find the nodes adjacent to a given node.
Current open Q's from me
A. the
@inferredtests give errors because the inferred type is a union type, but the output types are either a union type or only the node types depending on the exact call.B. handling nothing types in above below. I can see adding a method for
tree::nothing, x::nothingtoo, but this seems like a good start.