Skip to content

Add inline and inbounds annotations to unsafe_dot #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wheeheee merged 4 commits into from
Jul 10, 2025
+3 −3
Merged

Add inline and inbounds annotations to unsafe_dot #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
585add6
Add inline and inbounds annotations to unsafe_dot
jacobga1998 Jul 9, 2025
ff983bb
Change unsafe_dot inline to callsite
jacobga1998 Jul 9, 2025
7fcbd9d
Add inline for both insafe_dot calls in interpolation filt!
jacobga1998 Jul 9, 2025
8253510
Move inline annotation in front of function call
jacobga1998 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Filters/stream_filt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,9 +497,9 @@ function filt!(buffer::AbstractVector{Tb}, self::FIRFilter{FIRRational{Th}}, x::
bufIdx += 1

if inputIdx < kernel.tapsPerϕ
accumulator = unsafe_dot(kernel.pfb, kernel.ϕIdx, history, x, inputIdx)
accumulator = @inline unsafe_dot(kernel.pfb, kernel.ϕIdx, history, x, inputIdx)
else
accumulator = unsafe_dot(kernel.pfb, kernel.ϕIdx, x, inputIdx)
accumulator = @inline unsafe_dot(kernel.pfb, kernel.ϕIdx, x, inputIdx)
end

buffer[bufIdx] = accumulator
Expand Down
2 changes: 1 addition & 1 deletion src/util.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ end
function unsafe_dot(a::AbstractMatrix, aColIdx::Integer, b::AbstractVector, bLastIdx::Integer)
aLen = size(a, 1)
bBaseIdx = bLastIdx - aLen
dotprod = a[1, aColIdx] * b[ bBaseIdx + 1]
@inbounds dotprod = a[1, aColIdx] * b[ bBaseIdx + 1]
@simd for i in 2:aLen
@inbounds dotprod += a[i, aColIdx] * b[bBaseIdx + i]
end
Expand Down
Loading