Support Decimals.jl v0.5 #307
Conversation
* Decimals.jl v0.5 drops decimal() function, replace it with parse(Decimal, "...") * workaround the difference between the printing precision of BigFloat and the storage precision of Decimal.
|
@iamed2 / @quinnj Could either of you review this PR? And, if it looks good to you, release a new patch version? A number of packages, e.g. Turing.jl or SymbolicUtils.jl indirectly depend on Decimals.jl |
|
bump |
|
I am trying to find the reviewers for the PR :) @ararslan, maybe you can take a look? The PR should help keeping the deps of LibPQ.jl-using projects up-to-date. |
|
Seems reasonable to me, though my knowledge of LibPQ and Decimals is pretty limited. I do not, however, have write access to this repository, so my review here doesn't actually mean anything. 😅 |
|
How do the modified tests run on Decimals 0.4.1? Was this behaviour always available? |
|
@iamed2 So LibPQ.jl and its tests should still run fine on Decimals.jl 0.4. Anything else I should consider for this PR? |
This is a version of PR #306 that, in addition to updating the Decimals.jl to 0.5, also fixes the decimals-related tests.
The details for the test fixes are in the 2nd commit message.
I think the remaining test failures (more allocs than expected and some error message inconsistencies) are not related to decimals.
Closes #306