-
Notifications
You must be signed in to change notification settings - Fork 142
3d inspection fix #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
3d inspection fix #1162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
===========================================
+ Coverage 70.12% 85.27% +15.14%
===========================================
Files 42 38 -4
Lines 2718 2614 -104
===========================================
+ Hits 1906 2229 +323
+ Misses 812 385 -427 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm wondering: isn't |
|
Nice work by the way :-) |
|
@hbsmith thank you for this, can you please address the comment by @Tortar so that we can merge this in? |
Currently 3D hover inspection is broken.
Minimal non working example:
Note that there's a visible arrow but none of the default inspection information.
I don't have a great understanding of Makie, but it seems like the issue had something to do with the way the position was being translated, and thus never recognizing any Agents in the position of the mouse. The changes I made fix this as minimally as I was able to, such that it avoids Bounds errors, and displays information of multiple agents if they're in the same position.
With the fix:

If someone thinks there's a better way to do this, be my guest, but at least it works nows.
Note that this should be merged after #1159