Skip to content
This repository was archived by the owner on Apr 28, 2021. It is now read-only.

remove depwarns #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove depwarns #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/callbacks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ returns `Signal{Vector{Compat.UTF8String}}`, which are absolute file paths
"""
function dropped_files(window, s::Signal{Vector{Compat.UTF8String}}=Signal(Compat.UTF8String[]))
GLFW.SetDropCallback(window, (window, files) -> begin
push!(s, map(utf8, files))
push!(s, map(Compat.String, files))
end)
s
end
Expand Down
6 changes: 3 additions & 3 deletions src/screen.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function openglerrorcallback(
|
| OpenGL Error!
| source: $(GLENUM(source).name) :: type: $(GLENUM(typ).name)
| $(ascii(bytestring(message, length)))
| $(ascii(Compat.String(message, length)))
|________________________________________________________________
"""
output = typ == GL_DEBUG_TYPE_ERROR ? error : info
Expand Down Expand Up @@ -199,15 +199,15 @@ function create_glcontext(
GLFW.WindowHint(wh...)
end

@osx_only begin
@static if is_apple()
if debugging
warn("OpenGL debug message callback not available on osx")
debugging = false
end
end
GLFW.WindowHint(GLFW.OPENGL_DEBUG_CONTEXT, Cint(debugging))

window = GLFW.CreateWindow(resolution..., utf8(name))
window = GLFW.CreateWindow(resolution..., Compat.String(name))
GLFW.MakeContextCurrent(window)

debugging && glDebugMessageCallbackARB(_openglerrorcallback, C_NULL)
Expand Down