Skip to content

Conversation

@christiangnrd
Copy link
Member

@christiangnrd christiangnrd commented Nov 23, 2025

Adds simdgroup and barrier function attributes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/metal.jl b/src/metal.jl
index 6f1749e..a79dec1 100644
--- a/src/metal.jl
+++ b/src/metal.jl
@@ -1034,7 +1034,7 @@ function annotate_air_intrinsics!(@nospecialize(job::CompilerJob), mod::LLVM.Mod
             # TODO: "memory(argmem: readwrite)" on LLVM 16+
             add_attributes("argmemonly", "nounwind")
 
-        # simdgroup
+            # simdgroup
         elseif match(r"air.simdgroup_matrix_8x8_multiply_accumulate", fn) !== nothing
             add_attributes("convergent", "mustprogress", "nounwind", "willreturn")
         elseif match(r"air.simdgroup_matrix_8x8_load", fn) !== nothing

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.21%. Comparing base (531dccd) to head (5ccad5b).

Files with missing lines Patch % Lines
src/metal.jl 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
- Coverage   75.28%   75.21%   -0.07%     
==========================================
  Files          24       24              
  Lines        3670     3676       +6     
==========================================
+ Hits         2763     2765       +2     
- Misses        907      911       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christiangnrd christiangnrd changed the title [Metal] Simdgroup intrinsic attributes and tweak target triple [Metal] Add some simdgroup and barrier intrinsic attributes Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants