Skip to content

Avoid callgraph recursion due to exception branch in get_global_id #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Mar 5, 2025

get_global_id() from SPIRVIntrinsics.jl has an exception branch, so the use in the exception printing here causes a call-graph recursion, even though the branch is never executed.

on-top of that this causes an infinite recursion in POCL pocl/pocl#1826

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Benchmark Results

main 2c60b7f... main/2c60b7f9266a11...
saxpy/default/Float16/1024 0.055 ± 0.026 ms 0.0452 ± 0.026 ms 1.22
saxpy/default/Float16/1048576 0.907 ± 0.032 ms 0.899 ± 0.035 ms 1.01
saxpy/default/Float16/16384 0.0665 ± 0.028 ms 0.0609 ± 0.025 ms 1.09
saxpy/default/Float16/2048 0.0573 ± 0.024 ms 0.0483 ± 0.023 ms 1.19
saxpy/default/Float16/256 0.0597 ± 0.027 ms 0.0421 ± 0.027 ms 1.42
saxpy/default/Float16/262144 0.276 ± 0.027 ms 0.27 ± 0.027 ms 1.02
saxpy/default/Float16/32768 0.0806 ± 0.029 ms 0.0747 ± 0.026 ms 1.08
saxpy/default/Float16/4096 0.0661 ± 0.026 ms 0.0559 ± 0.025 ms 1.18
saxpy/default/Float16/512 0.0609 ± 0.027 ms 0.0466 ± 0.027 ms 1.31
saxpy/default/Float16/64 0.0596 ± 0.027 ms 0.0447 ± 0.03 ms 1.33
saxpy/default/Float16/65536 0.113 ± 0.029 ms 0.103 ± 0.027 ms 1.1
saxpy/default/Float32/1024 0.0588 ± 0.026 ms 0.0548 ± 0.028 ms 1.07
saxpy/default/Float32/1048576 0.49 ± 0.029 ms 0.477 ± 0.052 ms 1.03
saxpy/default/Float32/16384 0.0568 ± 0.026 ms 0.0544 ± 0.023 ms 1.04
saxpy/default/Float32/2048 0.0504 ± 0.024 ms 0.0458 ± 0.023 ms 1.1
saxpy/default/Float32/256 0.0612 ± 0.026 ms 0.0457 ± 0.028 ms 1.34
saxpy/default/Float32/262144 0.167 ± 0.035 ms 0.155 ± 0.035 ms 1.08
saxpy/default/Float32/32768 0.0627 ± 0.027 ms 0.0608 ± 0.025 ms 1.03
saxpy/default/Float32/4096 0.0594 ± 0.025 ms 0.0506 ± 0.024 ms 1.17
saxpy/default/Float32/512 0.0602 ± 0.027 ms 0.0446 ± 0.028 ms 1.35
saxpy/default/Float32/64 0.0629 ± 0.027 ms 0.0458 ± 0.029 ms 1.37
saxpy/default/Float32/65536 0.0824 ± 0.029 ms 0.0757 ± 0.029 ms 1.09
saxpy/default/Float64/1024 0.0524 ± 0.026 ms 0.0437 ± 0.027 ms 1.2
saxpy/default/Float64/1048576 0.551 ± 0.12 ms 0.533 ± 0.099 ms 1.03
saxpy/default/Float64/16384 0.06 ± 0.027 ms 0.0559 ± 0.025 ms 1.07
saxpy/default/Float64/2048 0.0484 ± 0.024 ms 0.0451 ± 0.023 ms 1.07
saxpy/default/Float64/256 0.0594 ± 0.027 ms 0.0405 ± 0.029 ms 1.47
saxpy/default/Float64/262144 0.18 ± 0.031 ms 0.174 ± 0.032 ms 1.04
saxpy/default/Float64/32768 0.0688 ± 0.028 ms 0.0668 ± 0.027 ms 1.03
saxpy/default/Float64/4096 0.0598 ± 0.026 ms 0.0494 ± 0.024 ms 1.21
saxpy/default/Float64/512 0.0612 ± 0.027 ms 0.0421 ± 0.028 ms 1.46
saxpy/default/Float64/64 0.0639 ± 0.026 ms 0.0404 ± 0.028 ms 1.58
saxpy/default/Float64/65536 0.091 ± 0.028 ms 0.088 ± 0.029 ms 1.03
saxpy/static workgroup=(1024,)/Float16/1024 0.0526 ± 0.026 ms 0.0455 ± 0.026 ms 1.15
saxpy/static workgroup=(1024,)/Float16/1048576 0.911 ± 0.032 ms 0.905 ± 0.036 ms 1.01
saxpy/static workgroup=(1024,)/Float16/16384 0.0605 ± 0.026 ms 0.0586 ± 0.024 ms 1.03
saxpy/static workgroup=(1024,)/Float16/2048 0.0559 ± 0.024 ms 0.0491 ± 0.023 ms 1.14
saxpy/static workgroup=(1024,)/Float16/256 0.0607 ± 0.026 ms 0.0439 ± 0.027 ms 1.38
saxpy/static workgroup=(1024,)/Float16/262144 0.271 ± 0.028 ms 0.268 ± 0.028 ms 1.01
saxpy/static workgroup=(1024,)/Float16/32768 0.0746 ± 0.026 ms 0.0724 ± 0.024 ms 1.03
saxpy/static workgroup=(1024,)/Float16/4096 0.0624 ± 0.027 ms 0.0513 ± 0.027 ms 1.22
saxpy/static workgroup=(1024,)/Float16/512 0.0589 ± 0.026 ms 0.0459 ± 0.027 ms 1.28
saxpy/static workgroup=(1024,)/Float16/64 0.0611 ± 0.026 ms 0.0447 ± 0.027 ms 1.37
saxpy/static workgroup=(1024,)/Float16/65536 0.107 ± 0.027 ms 0.0999 ± 0.025 ms 1.07
saxpy/static workgroup=(1024,)/Float32/1024 0.0571 ± 0.026 ms 0.0561 ± 0.027 ms 1.02
saxpy/static workgroup=(1024,)/Float32/1048576 0.475 ± 0.036 ms 0.463 ± 0.052 ms 1.02
saxpy/static workgroup=(1024,)/Float32/16384 0.0545 ± 0.025 ms 0.0528 ± 0.024 ms 1.03
saxpy/static workgroup=(1024,)/Float32/2048 0.0495 ± 0.024 ms 0.045 ± 0.023 ms 1.1
saxpy/static workgroup=(1024,)/Float32/256 0.0594 ± 0.026 ms 0.0557 ± 0.027 ms 1.07
saxpy/static workgroup=(1024,)/Float32/262144 0.162 ± 0.035 ms 0.154 ± 0.034 ms 1.05
saxpy/static workgroup=(1024,)/Float32/32768 0.0606 ± 0.027 ms 0.0589 ± 0.025 ms 1.03
saxpy/static workgroup=(1024,)/Float32/4096 0.0549 ± 0.026 ms 0.0485 ± 0.026 ms 1.13
saxpy/static workgroup=(1024,)/Float32/512 0.0616 ± 0.026 ms 0.0468 ± 0.027 ms 1.32
saxpy/static workgroup=(1024,)/Float32/64 0.062 ± 0.026 ms 0.0459 ± 0.026 ms 1.35
saxpy/static workgroup=(1024,)/Float32/65536 0.0788 ± 0.029 ms 0.0733 ± 0.028 ms 1.08
saxpy/static workgroup=(1024,)/Float64/1024 0.0545 ± 0.026 ms 0.0432 ± 0.026 ms 1.26
saxpy/static workgroup=(1024,)/Float64/1048576 0.558 ± 0.1 ms 0.509 ± 0.055 ms 1.1
saxpy/static workgroup=(1024,)/Float64/16384 0.058 ± 0.026 ms 0.055 ± 0.025 ms 1.06
saxpy/static workgroup=(1024,)/Float64/2048 0.0492 ± 0.024 ms 0.0446 ± 0.023 ms 1.1
saxpy/static workgroup=(1024,)/Float64/256 0.0632 ± 0.025 ms 0.0438 ± 0.027 ms 1.44
saxpy/static workgroup=(1024,)/Float64/262144 0.176 ± 0.03 ms 0.171 ± 0.032 ms 1.03
saxpy/static workgroup=(1024,)/Float64/32768 0.0689 ± 0.027 ms 0.0618 ± 0.025 ms 1.11
saxpy/static workgroup=(1024,)/Float64/4096 0.0596 ± 0.026 ms 0.0475 ± 0.026 ms 1.26
saxpy/static workgroup=(1024,)/Float64/512 0.0616 ± 0.026 ms 0.0428 ± 0.026 ms 1.44
saxpy/static workgroup=(1024,)/Float64/64 0.0627 ± 0.025 ms 0.0439 ± 0.026 ms 1.43
saxpy/static workgroup=(1024,)/Float64/65536 0.0902 ± 0.029 ms 0.0826 ± 0.028 ms 1.09
time_to_load 1.18 ± 0.02 s 1.16 ± 0.025 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (03a2c55) to head (2c60b7f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #579   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         21      21           
  Lines       1575    1571    -4     
=====================================
+ Misses      1575    1571    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

vchuravy commented Mar 5, 2025

@vchuravy vchuravy merged commit 6e64d84 into main Mar 12, 2025
21 of 32 checks passed
@vchuravy vchuravy deleted the vc/no_exception_printing branch March 12, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant