-
Notifications
You must be signed in to change notification settings - Fork 74
Avoid callgraph recursion due to exception branch in get_global_id #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 21 21
Lines 1575 1571 -4
=====================================
+ Misses 1575 1571 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
get_global_id()
from SPIRVIntrinsics.jl has an exception branch, so the use in the exception printing here causes a call-graph recursion, even though the branch is never executed.on-top of that this causes an infinite recursion in POCL pocl/pocl#1826