Skip to content

Use Printf to report errors from POCL #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Use Printf to report errors from POCL #592

wants to merge 3 commits into from

Conversation

vchuravy
Copy link
Member

  • enable printf in errors again
  • turn off 1.10 testing

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (afd66e4) to head (c17b340).

Files with missing lines Patch % Lines
src/pocl/device/runtime.jl 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (afd66e4) and HEAD (c17b340). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (afd66e4) HEAD (c17b340)
12 10
Additional details and impacted files
@@                 Coverage Diff                  @@
##           vc/pocl_upstream    #592       +/-   ##
====================================================
- Coverage             47.52%   0.00%   -47.53%     
====================================================
  Files                    22      21        -1     
  Lines                  1715    1575      -140     
====================================================
- Hits                    815       0      -815     
- Misses                  900    1575      +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Benchmark Results

main c17b340... main/c17b34036eaa12...
saxpy/default/Float16/1024 0.0552 ± 0.026 ms 0.0563 ± 0.026 ms 0.98
saxpy/default/Float16/1048576 0.9 ± 0.022 ms 0.905 ± 0.025 ms 0.995
saxpy/default/Float16/16384 0.0714 ± 0.027 ms 0.0627 ± 0.026 ms 1.14
saxpy/default/Float16/2048 0.0509 ± 0.023 ms 0.0482 ± 0.021 ms 1.06
saxpy/default/Float16/256 0.06 ± 0.027 ms 0.05 ± 0.028 ms 1.2
saxpy/default/Float16/262144 0.273 ± 0.024 ms 0.271 ± 0.024 ms 1.01
saxpy/default/Float16/32768 0.0852 ± 0.027 ms 0.077 ± 0.026 ms 1.11
saxpy/default/Float16/4096 0.0635 ± 0.023 ms 0.0556 ± 0.023 ms 1.14
saxpy/default/Float16/512 0.0587 ± 0.027 ms 0.0467 ± 0.027 ms 1.25
saxpy/default/Float16/64 0.0607 ± 0.027 ms 0.0455 ± 0.029 ms 1.33
saxpy/default/Float16/65536 0.116 ± 0.027 ms 0.105 ± 0.026 ms 1.11
saxpy/default/Float32/1024 0.0544 ± 0.026 ms 0.048 ± 0.027 ms 1.13
saxpy/default/Float32/1048576 0.484 ± 0.025 ms 0.476 ± 0.051 ms 1.02
saxpy/default/Float32/16384 0.0588 ± 0.027 ms 0.0543 ± 0.023 ms 1.08
saxpy/default/Float32/2048 0.0474 ± 0.022 ms 0.0457 ± 0.021 ms 1.04
saxpy/default/Float32/256 0.0598 ± 0.027 ms 0.0464 ± 0.029 ms 1.29
saxpy/default/Float32/262144 0.169 ± 0.033 ms 0.152 ± 0.033 ms 1.11
saxpy/default/Float32/32768 0.0631 ± 0.026 ms 0.0603 ± 0.023 ms 1.05
saxpy/default/Float32/4096 0.0616 ± 0.025 ms 0.0511 ± 0.025 ms 1.21
saxpy/default/Float32/512 0.0587 ± 0.028 ms 0.0452 ± 0.028 ms 1.3
saxpy/default/Float32/64 0.059 ± 0.027 ms 0.0431 ± 0.028 ms 1.37
saxpy/default/Float32/65536 0.0779 ± 0.028 ms 0.0743 ± 0.027 ms 1.05
saxpy/default/Float64/1024 0.0497 ± 0.026 ms 0.0461 ± 0.027 ms 1.08
saxpy/default/Float64/1048576 0.521 ± 0.049 ms 0.518 ± 0.043 ms 1.01
saxpy/default/Float64/16384 0.0592 ± 0.026 ms 0.0568 ± 0.025 ms 1.04
saxpy/default/Float64/2048 0.0468 ± 0.022 ms 0.0461 ± 0.021 ms 1.01
saxpy/default/Float64/256 0.0596 ± 0.028 ms 0.0449 ± 0.029 ms 1.33
saxpy/default/Float64/262144 0.178 ± 0.026 ms 0.175 ± 0.031 ms 1.02
saxpy/default/Float64/32768 0.068 ± 0.026 ms 0.065 ± 0.025 ms 1.05
saxpy/default/Float64/4096 0.0614 ± 0.026 ms 0.0513 ± 0.025 ms 1.2
saxpy/default/Float64/512 0.056 ± 0.028 ms 0.0435 ± 0.028 ms 1.29
saxpy/default/Float64/64 0.0585 ± 0.028 ms 0.0418 ± 0.029 ms 1.4
saxpy/default/Float64/65536 0.0909 ± 0.026 ms 0.0816 ± 0.026 ms 1.11
saxpy/static workgroup=(1024,)/Float16/1024 0.0508 ± 0.026 ms 0.048 ± 0.026 ms 1.06
saxpy/static workgroup=(1024,)/Float16/1048576 0.908 ± 0.024 ms 0.92 ± 0.03 ms 0.986
saxpy/static workgroup=(1024,)/Float16/16384 0.067 ± 0.025 ms 0.0595 ± 0.024 ms 1.13
saxpy/static workgroup=(1024,)/Float16/2048 0.0537 ± 0.024 ms 0.0496 ± 0.023 ms 1.08
saxpy/static workgroup=(1024,)/Float16/256 0.0588 ± 0.026 ms 0.0486 ± 0.027 ms 1.21
saxpy/static workgroup=(1024,)/Float16/262144 0.273 ± 0.026 ms 0.272 ± 0.026 ms 1
saxpy/static workgroup=(1024,)/Float16/32768 0.0826 ± 0.025 ms 0.0735 ± 0.025 ms 1.12
saxpy/static workgroup=(1024,)/Float16/4096 0.0538 ± 0.026 ms 0.049 ± 0.026 ms 1.1
saxpy/static workgroup=(1024,)/Float16/512 0.0577 ± 0.026 ms 0.0465 ± 0.026 ms 1.24
saxpy/static workgroup=(1024,)/Float16/64 0.0599 ± 0.026 ms 0.0445 ± 0.028 ms 1.35
saxpy/static workgroup=(1024,)/Float16/65536 0.113 ± 0.026 ms 0.104 ± 0.026 ms 1.08
saxpy/static workgroup=(1024,)/Float32/1024 0.0552 ± 0.026 ms 0.0456 ± 0.027 ms 1.21
saxpy/static workgroup=(1024,)/Float32/1048576 0.474 ± 0.028 ms 0.465 ± 0.052 ms 1.02
saxpy/static workgroup=(1024,)/Float32/16384 0.0574 ± 0.026 ms 0.0529 ± 0.024 ms 1.09
saxpy/static workgroup=(1024,)/Float32/2048 0.0469 ± 0.023 ms 0.0451 ± 0.022 ms 1.04
saxpy/static workgroup=(1024,)/Float32/256 0.059 ± 0.026 ms 0.0464 ± 0.026 ms 1.27
saxpy/static workgroup=(1024,)/Float32/262144 0.165 ± 0.035 ms 0.159 ± 0.034 ms 1.04
saxpy/static workgroup=(1024,)/Float32/32768 0.0606 ± 0.026 ms 0.0597 ± 0.024 ms 1.02
saxpy/static workgroup=(1024,)/Float32/4096 0.0567 ± 0.026 ms 0.0466 ± 0.026 ms 1.22
saxpy/static workgroup=(1024,)/Float32/512 0.0587 ± 0.026 ms 0.0456 ± 0.026 ms 1.29
saxpy/static workgroup=(1024,)/Float32/64 0.0587 ± 0.026 ms 0.0438 ± 0.026 ms 1.34
saxpy/static workgroup=(1024,)/Float32/65536 0.0747 ± 0.028 ms 0.0742 ± 0.026 ms 1.01
saxpy/static workgroup=(1024,)/Float64/1024 0.0533 ± 0.026 ms 0.0469 ± 0.027 ms 1.14
saxpy/static workgroup=(1024,)/Float64/1048576 0.521 ± 0.05 ms 0.564 ± 0.072 ms 0.923
saxpy/static workgroup=(1024,)/Float64/16384 0.0595 ± 0.026 ms 0.055 ± 0.025 ms 1.08
saxpy/static workgroup=(1024,)/Float64/2048 0.0464 ± 0.022 ms 0.045 ± 0.022 ms 1.03
saxpy/static workgroup=(1024,)/Float64/256 0.0584 ± 0.025 ms 0.0445 ± 0.026 ms 1.31
saxpy/static workgroup=(1024,)/Float64/262144 0.179 ± 0.027 ms 0.181 ± 0.031 ms 0.989
saxpy/static workgroup=(1024,)/Float64/32768 0.0664 ± 0.026 ms 0.0633 ± 0.024 ms 1.05
saxpy/static workgroup=(1024,)/Float64/4096 0.0564 ± 0.026 ms 0.0482 ± 0.026 ms 1.17
saxpy/static workgroup=(1024,)/Float64/512 0.0569 ± 0.026 ms 0.0446 ± 0.026 ms 1.28
saxpy/static workgroup=(1024,)/Float64/64 0.0571 ± 0.026 ms 0.0429 ± 0.026 ms 1.33
saxpy/static workgroup=(1024,)/Float64/65536 0.0862 ± 0.028 ms 0.081 ± 0.027 ms 1.06
time_to_load 1.38 ± 0.0078 s 1.44 ± 0.0019 s 0.953

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Base automatically changed from vc/pocl_upstream to main April 28, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant