juliarize #2
Open
juliarize #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's make this public as well? |
|
Make what public? |
|
The repo, it's currently private |
|
Haha totally I didn't know that |
|
Ok this is now a huge refactor.
|
asinghvi17
reviewed
May 12, 2025
| "direction" => "east", | ||
| "unit" => UNIT_DEGREE, | ||
| ), | ||
| OrderedDict( |
There was a problem hiding this comment.
Let's make these LittleDicts (basically vectors) instead, apparently they are a lot faster
There was a problem hiding this comment.
Are they ordered? I just wanted to keep the output organised and non random
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I juliarized this a bit while getting my head around how it works.
But I find the layout and naming (of the original pyproj) quite unintuitive - CoordinateOperation and Conversion are really opaque names.
We also still have un-julian type syntax function calls like
AzimuthalEquidistantConversion.To fix both confusion things at once they should probably be
_azimuthal_equidistant__to_proj_json_dictto match the opposite function_azimuthal_equidistant__to_cf.Then
ProjJSONCoordinateOperationcan just beProjJSONDictas we are directly converting it to ProjJSON withJSON3.write(operation.dict)anyway, there is no operation (well the operation is that later Proj.jl conversions know this is a converted crs, and process it accordingly. But it's valid ProjJSON in the Dictionary, it could hold other ProjJSON classes and work for them too)