Skip to content

Remove ambiguity and implement getgeom, ngeom for Wrappers.Point #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asinghvi17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove ambiguity and implement getgeom, ngeom for Wrappers.Point #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/wrappers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,10 @@ convert(::Type{Point}, ::PointTrait, geom) = Point(geom)
convert(::Type{Point}, ::PointTrait, geom::Point) = geom
extent(trait::PointTrait, geom::Point) = extent(trait, parent(geom))

ngeom(::PointTrait, geom::Point) = 0
getgeom(::PointTrait, geom::Point) = nothing
getgeom(::PointTrait, geom::Point, i) = nothing
Comment on lines +321 to +323
Copy link
Member Author

@asinghvi17 asinghvi17 Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ngeom(::PointTrait, geom::Point) = 0
getgeom(::PointTrait, geom::Point) = nothing
getgeom(::PointTrait, geom::Point, i) = nothing
ngeom(::PointTrait, geom::Point) = error("`GI.ngeom` on a Point is not allowed! To get the number of dimensions use `GI.ncoord` instead.")
getgeom(::PointTrait, geom::Point) = error("`GI.getgeom` on a Point is not allowed! To get the number of dimensions use `GI.getcoord` instead, or `GI.x, GI.y, GI.z, GI.t`")
getgeom(::PointTrait, geom::Point, i) = error("`GI.getgeom` on a Point is not allowed! To get the number of dimensions use `GI.getcoord` instead, or `GI.x, GI.y, GI.z, GI.t`")


x(trait::PointTrait, geom::Point) = x(trait, parent(geom))
y(trait::PointTrait, geom::Point) = y(trait, parent(geom))
z(trait::PointTrait, geom::Point{true}) = z(trait, parent(geom))
Expand Down