Skip to content

add 2d extent support #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asinghvi17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add 2d extent support #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions GeoInterfaceMakie/src/GeoInterfaceMakie.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,18 @@ to_multipoint(geom::AbstractVector) = to_multipoint.(GeoInterface.trait.(geom),
to_multipoint(::GeoInterface.PointTrait, geom) = GB.MultiPoint([GeoInterface.convert(GB, geom)])
to_multipoint(::GeoInterface.MultiPointTrait, geom) = GeoInterface.convert(GB, geom)

# Special handling for extents - treat 2d extents as Rect2

using GeoInterface: Extent

const _TWOD_TUPLE_EXTENT_TYPE = Union{<: Extent{(:X, :Y), T}, <: Extent{(:Y, :X), T}} where T <: NTuple{2, NTuple{2, <: Number}} # wide type range to allow unitful extents eventually

function _ext2_to_rect2(ext::Extent)
Rect2((ext.X[1], ext.Y[1]), (ext.X[2] - ext.X[1], ext.Y[2] - ext.Y[1]))
end

Makie.convert_single_argument(ext::_TWOD_TUPLE_EXTENT_TYPE) = _ext2_to_rect2(ext)
Makie.convert_single_argument(ext::AbstractVector{<: _TWOD_TUPLE_EXTENT_TYPE}) = _ext2_to_rect2.(ext)

# TODO
# Features and Feature collections
Expand Down
Loading