Add a convert method for (module, trait, geom) #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
commented
May 15, 2025
Member
|
Makes sense to me |
This allows the trait to be passed through completely from the time of discovery to the bottom level, which decreases allocations and dynamic dispatch in long call chains like GeometryOps' `apply`.
asinghvi17
force-pushed
the
as/convert-module-trait-geom
branch
from
2e1d73a to
4d1d420
Compare
rafaqz
approved these changes
Sep 8, 2025
asinghvi17
commented
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the trait to be passed through completely from the time of discovery to the bottom level, which decreases allocations and dynamic dispatch in long call chains like GeometryOps'
apply.If this makes sense to add then I will add tests, docs, etc.