Move MakieCore and GeometryBasics to an extension of GeoInterfaceMakie #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves MakieCore and GeometryBasics to an extension. Resolving JuliaGeo/Shapefile.jl#139
Its a little more annoying than it could be because extending the macro in the extension seems to have world age issues - the extensions wont see the new methods added even if you can see them in the REPL before they load!
But, instead of putting the macro in an extension we can just keep it in the package and make a breaking change.
In the calling package we just add Makie or MakieCore manually:
And it all seems to work fine, and MakieCore/GeometryBasics dependencies are now optional.