Skip to content

add geometrycolumn kwarg to write #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add geometrycolumn kwarg to write #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions src/writer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ emptytable(n::Integer) = [(;all_missing=missing) for _ in 1:n]
emptytable(itr) = [(;all_missing=missing) for _ in itr]


function get_writer(obj)
function get_writer(obj; geometrycolumn = first(GI.geometrycolumns(obj)))
crs = try; GI.crs(obj); catch; nothing; end

if GI.isgeometry(obj) || ismissing(obj)
Expand All @@ -63,16 +63,27 @@ function get_writer(obj)
tbl = isempty(feats) ? emptytable(geoms) : feats
return Writer(geoms, tbl, crs)
elseif Tables.istable(obj)
# Note: this transformation is done in DBFTables.jl anyway
# so we lose nothing by doing it here.
tbl = getfield(Tables.dictcolumntable(obj), :values) # an OrderedDict
geomfields = findall(tbl) do data
all(x -> ismissing(x) || GI.isgeometry(x), data) && any(!ismissing, data)
if !(geometrycolumn in Tables.columnnames(tbl))
@warn "No geometry column found in table, though $geometrycolumn was provided. Using the first column that satisfies `GeoInterface.isgeometry`."
geomfields = findall(tbl) do data
all(x -> ismissing(x) || GI.isgeometry(x), data) && any(!ismissing, data)
end
geometrycolumn = geomfields
end
if length(geomfields) > 1
@warn "Multiple geometry columns detected: $geomfields. $(geomfields[1]) will be used " *
"and the rest discarded."
if (geometrycolumn isa Tuple || geometrycolumn isa Vector)
if length(geometrycolumn) > 1
@warn "Multiple geometry columns detected: $geometrycolumn. $(geometrycolumn[1]) will be used " *
"and the rest discarded."
geometrycolumn = geometrycolumn[1]
else
geometrycolumn = only(geometrycolumn)
end
end
geoms = :geometry in keys(tbl) ? tbl[:geometry] : tbl[geomfields[1]]
foreach(x -> delete!(tbl, x), geomfields) # drop unused geometry columns
geoms = Tables.getcolumn(tbl, geometrycolumn)
foreach(x -> delete!(tbl, x), (GI.geometrycolumns(obj)..., geometrycolumn)) # drop unused geometry columns
tbl = isempty(tbl) ? emptytable(geoms) : tbl
return Writer(geoms, tbl, crs)
elseif all(GI.isgeometry, obj)
Expand Down Expand Up @@ -254,7 +265,7 @@ function write(path::AbstractString, o::Writer; force=false)
end

"""
write(path::AbstractString, obj; force=false)
write(path::AbstractString, obj; force=false, geometrycolumn)

Write `obj` in the shapefile (.shp, .shx, .dbf, and possibly .prj files) format. `obj` must satisfy
one of:
Expand All @@ -266,7 +277,7 @@ one of:
5. An iterator of elements that satisfy `GeoInterface.isgeometry(element)`.
"""

write(path::AbstractString, obj; force=false) = write(path, get_writer(obj); force)
write(path::AbstractString, obj; force=false, geometrycolumn = first(GI.geometrycolumns(obj))) = write(path, get_writer(obj, geometrycolumn=geometrycolumn); force)


# Geometry writing
Expand Down
Loading