-
Notifications
You must be signed in to change notification settings - Fork 92
Refactor adjsort
into adjsortperm
#1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b85def9
Improve type stability/specifity in half-edge construction functions
halleysfifthinc 34108df
Use more looping to avoid intermediate allocs
halleysfifthinc aab2312
Refactor `adjsort` to work with indices directly and return a sort-perm
halleysfifthinc 9b8f618
Refactor adjsortperm
juliohm d1d4866
Tweak refactor
halleysfifthinc 5f2eecf
Improve adjacency (substantially reduce number of adjacency discontin…
halleysfifthinc f984f34
Final(?) refactor of `adjsortperm`
halleysfifthinc a69aec5
update comments
halleysfifthinc 46ac6ec
Only create the predicate once (saves some allocs)
halleysfifthinc fc1fafb
Split actual adjacency check into separate function and union-split f…
halleysfifthinc b9edf2d
Use eachindex instead of 1based
halleysfifthinc 5180ec6
Fix formatting
halleysfifthinc 03cf364
Update tests again for slightly different ordering of new `adjsortper…
halleysfifthinc 5dacc16
First round of cleanup
juliohm 1d3e77f
Second round of cleanup
juliohm 828f0b4
Third round of cleanup
juliohm 2136eee
Fourth round of review
juliohm e75b1e9
Update src/topologies/halfedge.jl
juliohm 7b665c8
Fix union-splitting
halleysfifthinc 7fc64c7
Revert Set initialization
halleysfifthinc b4e2e15
Call indices from within `adjelem!`
halleysfifthinc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.