Skip to content

Replace LScene by Axis3 (attempt 2) #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliohm wants to merge 3 commits into
base: master
Choose a base branch
from
+37 −3
Open

Replace LScene by Axis3 (attempt 2) #1357

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e14097
Choose default axis attributes
juliohm Apr 11, 2026
0b6627f
Add default axis labels
juliohm Apr 24, 2026
4389863
Refactor axis argument
juliohm Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions ext/MeshesMakieExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,43 @@ Makie.@recipe(Viz, object) do scene
end

# choose between 2D and 3D axis
Makie.args_preferred_axis(g::Geometry) = embeddim(g) === 3 ? Makie.LScene : Makie.Axis
Makie.args_preferred_axis(d::Domain) = embeddim(d) === 3 ? Makie.LScene : Makie.Axis
Makie.args_preferred_axis(::AbstractVector{<:Vec{Dim}}) where {Dim} = Dim === 3 ? Makie.LScene : Makie.Axis
Makie.args_preferred_axis(g::Geometry) = axis(embeddim(g))
Makie.args_preferred_axis(d::Domain) = axis(embeddim(d))
Makie.args_preferred_axis(::Vec{Dim}) where {Dim} = axis(Dim)
Makie.args_preferred_axis(v::AbstractVector{<:Vec}) = Makie.args_preferred_axis(first(v))

axis(dim) = dim === 3 ? Makie.Axis3 : Makie.Axis

# choose default axis attributes
Makie.preferred_axis_attributes(_, g::Geometry) = axisattributes(g)
Makie.preferred_axis_attributes(_, d::Domain) = axisattributes(d)
Makie.preferred_axis_attributes(_, ::Vec{Dim,ℒ}) where {Dim,ℒ} = axisattributes(Dim, ℒ)
Makie.preferred_axis_attributes(A, v::AbstractVector{<:Vec}) = Makie.preferred_axis_attributes(A, first(v))

function axisattributes(g)
aspect = fixaspect(embeddim(g))
labels = xyzlabels(crs(g))
merge(aspect, labels)
end

function axisattributes(Dim, ℒ)
aspect = fixaspect(Dim)
labels = xyzlabels(Cartesian{NoDatum,Dim,ℒ})
merge(aspect, labels)
end

fixaspect(dim) = dim === 3 ? (aspect=:data, viewmode=:free, perspectiveness=0.5) : (aspect=Makie.DataAspect(),)

function xyzlabels(CRS)
u = CoordRefSystems.lentype(CRS) |> unit
if CoordRefSystems.ndims(CRS) === 3
(xlabel="X [$u]", ylabel="Y [$u]", zlabel="Z [$u]")
elseif CRS <: CoordRefSystems.Projected
(xlabel="Easting [$u]", ylabel="Northing [$u]")
else
(xlabel="X [$u]", ylabel="Y [$u]")
end
end

# color handling
include("colors.jl")
Expand Down
Loading