Remove node_features, edge_features, graph_features methods#639
Open
calebjubal wants to merge 1 commit intoJuliaGraphs:masterfrom
Open
Remove node_features, edge_features, graph_features methods#639calebjubal wants to merge 1 commit intoJuliaGraphs:masterfrom
calebjubal wants to merge 1 commit intoJuliaGraphs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
node_features,edge_features, andgraph_featureshelper functions and updates all usages to direct property access.Motivation
These convenience functions were problematic because:
They only worked when there was a single feature array in
ndata/edata/gdataThey threw an error when multiple feature arrays existed, which was confusing
Direct property access (
g.ndata.x,g.edata.e,g.gdata.u) is more explicit and flexibleChanges
Removed:
node_features(g::GNNGraph)function definitionedge_features(g::GNNGraph)function definitiongraph_features(g::GNNGraph)function definitionUpdated to use direct property access:
Test files updated accordingly
Migration
Users should replace: