Skip to content

CompatHelper: add new compat entry for Makie in [weakdeps] at version 0.22, (keep existing compat)#22

Closed
github-actions[bot] wants to merge 1 commit intomasterfrom
compathelper/new_version/2025-06-05-15-05-36-871-02123441278
Closed

CompatHelper: add new compat entry for Makie in [weakdeps] at version 0.22, (keep existing compat)#22
github-actions[bot] wants to merge 1 commit intomasterfrom
compathelper/new_version/2025-06-05-15-05-36-871-02123441278

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 5, 2025

This pull request sets the compat entry for the Makie package to 0.22.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@peremato peremato force-pushed the compathelper/new_version/2025-06-05-15-05-36-871-02123441278 branch from 41af400 to c58c03d Compare June 5, 2025 15:05
@fhagemann
Copy link
Contributor

Combining this with #28 should be good to go.

Makie@0.23 introduced breaking changes to arrows, but this isn't used here as far as I am aware.

Geant4_julia_jll = "0.2"
GeometryBasics = "0.4,0.5"
IGLWrap_jll = "2.4.0"
Makie = "0.22"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Makie = "0.22"
Makie = "0.22, 0.23"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would make #28 obsolete.

@fhagemann
Copy link
Contributor

Superseded by #31

@peremato peremato closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants