Skip to content

Fix for Drawing boolean solids #29 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peremato merged 1 commit into from
Jun 19, 2025
Merged

Fix for Drawing boolean solids #29 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ CSV = "0.10"
CxxWrap = "0.16"
Geant4_julia_jll = "0.2"
GeometryBasics = "0.5"
IGLWrap_jll = "2.4.0"
IGLWrap_jll = "2.6.0"
julia = "1.9"
FHist = "0.11"

Expand Down
10 changes: 4 additions & 6 deletions ext/G4Vis/Boolean.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,10 @@ const operation = Dict("G4UnionSolid" => 0, "G4IntersectionSolid" => 1, "G4Subtr

function GeometryBasics.mesh(s::G4BooleanSolid)
if isdefined(IGLWrap_jll, :libiglwrap)
println("IGLWrap_jll is available but interface needs to be fixed for drawing boolean solids (TODO)")
GeometryBasics.mesh(Point3{Float64}[], QuadFace{Int32}[])
# op = operation[GetEntityType(s)]
# left = GetConstituentSolid(s, 0)
# right = GetConstituentSolid(s, 1)
# boolean(op, GeometryBasics.mesh(left), GeometryBasics.mesh(right))
op = operation[GetEntityType(s)]
left = GetConstituentSolid(s, 0)
right = GetConstituentSolid(s, 1)
boolean(op, GeometryBasics.mesh(left), GeometryBasics.mesh(right))
else
println("IGLWrap_jll is not available for current platform $(Sys.MACHINE) and is needed for drawing boolean solids")
GeometryBasics.mesh(Point3{Float64}[], QuadFace{Int32}[])
Expand Down
Loading