Rationalise final jets#198
Merged
graeme-a-stewart merged 9 commits intoJuliaHEP:mainfrom Aug 27, 2025
Merged
Conversation
graeme-a-stewart
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 77.25% 80.00% +2.74%
==========================================
Files 21 21
Lines 1319 1315 -4
==========================================
+ Hits 1019 1052 +33
+ Misses 300 263 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
graeme-a-stewart
force-pushed
the
rationalise-final-jets
branch
from
29b3dd6 to
e7b01cc
Compare
This was referenced Aug 11, 2025
Closed
m-fila
reviewed
Aug 19, 2025
graeme-a-stewart
force-pushed
the
rationalise-final-jets
branch
from
800f173 to
aa12eef
Compare
Member
Author
|
I had a look at the nightly build failures and it looks like it's a bad build - I can hardly run anything on my laptop against the current nightly. I checked 1.12 and it's fine with this PR. |
Member
|
Yes, at least LoopVectorization fails to build in with the nightlies |
m-fila
approved these changes
Aug 27, 2025
The default return values from exclusive and inclusive jet selectors were wrong, as the LorentzVectorCyl was created mistakenly with rapidity(jet) instead of eta(jet). This went unnoticed as the FinalJets reversed the mistake, treating eta() as if it was rapidity(). In testing, there is quite a precision loss involved in conversion to a LorentzVectorCyl as this involves converting from (px,py,py,E) to (pT,eta,phi,m), then re-extracting (rapidity,phi,pT). It is the rapidity<->phi which is problematic. So, the default return type has been changed to be a LorentzVector as this matches better the internal representation of PseudoJet and EEJet. Also now import eta() and pt() methods for LorentzVectorCyl and LorentzVector. Decrease the tolerance on the pT test from 1e-6 to 1e-7 (for Float64).
Test if different struct selectors work for selected jets, both inclusive and exclusive. Add mass and mass2 "imports" for LorentzVector and LorentzVectorHEP.
Pass kwargs properly and don't rely on the ≈ alias. Use the default equality implementation.
graeme-a-stewart
force-pushed
the
rationalise-final-jets
branch
from
aa12eef to
50a40ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default return values from exclusive and inclusive jet selectors were wrong, as the
LorentzVectorCylwas created mistakenly withrapidity(jet)instead ofeta(jet). This went unnoticed as the FinalJets reversed the mistake, treatingeta()as if it wasrapidity()(see #197).In testing, there is quite a precision loss involved in conversion to a
LorentzVectorCylas this involves converting from(px,py,py,E)to(pT,eta,phi,m), then re-extracting(rapidity,phi,pT). It is the rapidity<->phi which is problematic. So, the default return type has been changed to be aLorentzVectoras this matches better the internal representation ofPseudoJetandEEJetas a (p,E) vector.Also now import
eta()andpt()methods forLorentzVectorCylandLorentzVector.Decrease the tolerance on the pT test from 1e-6 to 1e-7 (for Float64).
Fixes #170 #197