allow exclusive and inclusive jets to return jet type used in clusterseq#118
Merged
graeme-a-stewart merged 1 commit intoJuliaHEP:mainfrom Jan 30, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 73.49% 73.61% +0.11%
==========================================
Files 18 18
Lines 1249 1247 -2
==========================================
Hits 918 918
+ Misses 331 329 -2 ☔ View full report in Codecov by Sentry. |
graeme-a-stewart
approved these changes
Jan 30, 2025
Member
graeme-a-stewart
left a comment
There was a problem hiding this comment.
Thank you @m-fila - this was overlooked when the parametrised version of ClusterSequence was introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing
exclusive_jetsandinclusive_jetsso they can return either aLorentzVectorCylor the type used for jets in input ClusterSequence.Previously it wasn't possible to obtain
EEjetfrominclusive_jets.For both inclusive and exclusive it was possible to try converting
ClusterSequence{EEjet}toPseudojet- now requesting wrong type will produceLorentzVectorCyl