Merged
Conversation
Use Match.jl to switch on the filename suffix
Member
Author
|
@Moelf - I was a little surprised not to find a generic utility to wrap the correct stream function. Did I miss anything? OTOH it's so not exactly rocket science, so maybe everyone just does roll their own... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 73.81% 73.89% +0.08%
==========================================
Files 18 18
Lines 1245 1249 +4
==========================================
+ Hits 919 923 +4
Misses 326 326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Moelf
reviewed
Mar 12, 2025
Member
I don't think you missed something, cuz we see https://github.com/JuliaIO/TranscodingStreams.jl/blob/ea4533afaf175443198f5d98009266b6b5f2d882/docs/src/examples.md?plain=1#L101-L110 in their example... |
This was a bit OTT for a 3-way choice, just use "if elself elseif else"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a small enhancement to support reading Zstd compressed files (
*.zst). Zstd can get 20% better compression than Gzip and reading is as fast (unlike LZMA).File opening is abstracted using a small utility wrapper, so reduces code duplication.
Closes #131