Implementing modules for Lund Jet Plane generation#184
Implementing modules for Lund Jet Plane generation#184graeme-a-stewart merged 5 commits intoJuliaHEP:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 76.92% 77.33% +0.40%
==========================================
Files 20 21 +1
Lines 1296 1319 +23
==========================================
+ Hits 997 1020 +23
Misses 299 299 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please make sure to use correct version of the formatter |
mattleblanc
left a comment
mattleblanc
left a comment
There was a problem hiding this comment.
Hi @sattwamo! Thanks very much for this code. As an LJP enthusiast, I took a quick look and left a couple (admittedly nitpick-y) questions for you.
Moved `generate_average_lund_image` function to `examples/lundplane/lund-plane-visualisation.jl` Included reference to original paper Removed redundant comments
|
Hi @sattwamo, thanks for pushing the changes. I think it looks good, but I can't resolve the threads -- I think that's in your hands. Cheers, |
Rephrase a few things in the documentation. Use LaTeXStrings for nicer axis labels on example. Add a max_allowable_R for the package (following Fastjet this is set to 1000) Make use of the delta_phi() function in deltaR() and deltar().
graeme-a-stewart
left a comment
graeme-a-stewart
left a comment
There was a problem hiding this comment.
Thank you @sattwamo! I pushed a few small changes myself and this looks good to go now.
* Implementing modules for Lund Jet Plane generation * Refactor Lund-plane utilities Moved `generate_average_lund_image` function to `examples/lundplane/lund-plane-visualisation.jl` Included reference to original paper Removed redundant comments * Fixed the issue with tests of LundPlane * Small fixes for Lund plane Rephrase a few things in the documentation. Use LaTeXStrings for nicer axis labels on example. Add a max_allowable_R for the package (following Fastjet this is set to 1000) Make use of the delta_phi() function in deltaR() and deltar(). * Minor formatting --------- Co-authored-by: Graeme A Stewart <graeme.andrew.stewart@cern.ch>
4 participants
Implemented functions to generate the primary Lund Jet Plane, following the logic and structure of the LundPlane reference implementation in FastJet.
Verified consistency with FastJet output — see comparison.pdf for detailed comparison plots.
Also fixed the issue with
constituent_indexesfunction.