Skip to content

Add cluster_hist_index argument for EDM4hep reconstructed particles #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graeme-a-stewart merged 2 commits into from
Feb 2, 2026
Merged

Add cluster_hist_index argument for EDM4hep reconstructed particles #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
660051d
Add cluster_hist_index argument
graeme-a-stewart Feb 2, 2026
14875a6
Add basic EDM4hep tests
graeme-a-stewart Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ julia = "1.10"
[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
ArgParse = "c7e460c6-2fb9-53a9-8c5b-16f535851c63"
EDM4hep = "eb32b910-dde9-4347-8fce-cd6be3498f0c"
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Aqua", "ArgParse", "Test", "JSON", "Random"]
test = ["Aqua", "ArgParse", "Test", "JSON", "Random", "EDM4hep"]
12 changes: 8 additions & 4 deletions ext/EDM4hepJets.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,23 @@ JetReconstruction.energy(recoparticle::ReconstructedParticle) = recoparticle.ene

Construct an EEJet from a ReconstructedParticle.
"""
function JetReconstruction.EEJet(recoparticle::ReconstructedParticle)
function JetReconstruction.EEJet(recoparticle::ReconstructedParticle;
cluster_hist_index::Int = 0)
EEJet(JetReconstruction.px(recoparticle), JetReconstruction.py(recoparticle),
JetReconstruction.pz(recoparticle), JetReconstruction.energy(recoparticle))
JetReconstruction.pz(recoparticle), JetReconstruction.energy(recoparticle);
cluster_hist_index)
end

"""
JetReconstruction.PseudoJet(recoparticle::ReconstructedParticle)

Construct an PseudoJet from a ReconstructedParticle.
"""
function JetReconstruction.PseudoJet(recoparticle::ReconstructedParticle)
function JetReconstruction.PseudoJet(recoparticle::ReconstructedParticle;
cluster_hist_index::Int = 0)
PseudoJet(JetReconstruction.px(recoparticle), JetReconstruction.py(recoparticle),
JetReconstruction.pz(recoparticle), JetReconstruction.energy(recoparticle))
JetReconstruction.pz(recoparticle), JetReconstruction.energy(recoparticle);
cluster_hist_index)
end

end
1 change: 1 addition & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ function main()
# Basic tests for the Jet types
include("test-jet-types.jl")
include("test-jet-constructors.jl")
include("test-edm4hep.jl")

# Jet utilities tests
include("test-jet-utils.jl")
Expand Down
26 changes: 26 additions & 0 deletions test/test-edm4hep.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Test that we can work with EDM4hep particles

include("common.jl")

using EDM4hep

dummyRecoParticle = ReconstructedParticle(energy = 4.0f0,
momentum = Vector3f(1.0f0, 2.0f0, 3.0f0))

@testset "Construction of jets from EDM4hep particles" begin
eej = EEJet(dummyRecoParticle)
pj = PseudoJet(dummyRecoParticle)
@test typeof(EEJet(dummyRecoParticle)) === EEJet
@test typeof(EEJet(dummyRecoParticle; cluster_hist_index = 99)) === EEJet
@test JetReconstruction.energy(eej) == dummyRecoParticle.energy
@test JetReconstruction.px(eej) == dummyRecoParticle.momentum.x
@test JetReconstruction.py(eej) == dummyRecoParticle.momentum.y
@test JetReconstruction.pz(eej) == dummyRecoParticle.momentum.z

@test typeof(PseudoJet(dummyRecoParticle)) === PseudoJet
@test typeof(PseudoJet(dummyRecoParticle; cluster_hist_index = 99)) === PseudoJet
@test JetReconstruction.energy(pj) == dummyRecoParticle.energy
@test JetReconstruction.px(pj) == dummyRecoParticle.momentum.x
@test JetReconstruction.py(pj) == dummyRecoParticle.momentum.y
@test JetReconstruction.pz(pj) == dummyRecoParticle.momentum.z
end
Loading