Fix KomaMRI UI tests: Using unsafe electron for Ubuntu, and skipped Apple Silicon tests during CI #565
Merged
cncastillo merged 24 commits intomasterfrom Jun 26, 2025
Merged
Fix KomaMRI UI tests: Using unsafe electron for Ubuntu, and skipped Apple Silicon tests during CI #565cncastillo merged 24 commits intomasterfrom
cncastillo merged 24 commits intomasterfrom
Conversation
cncastillo
requested changes
Jun 23, 2025
cncastillo
requested changes
Jun 24, 2025
Member
cncastillo
left a comment
There was a problem hiding this comment.
Check comment. Can you check if removing the kaleido compat fixes MacOS?
cncastillo
requested changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsafe_blink macro implementation to fix ubuntu CI test