Skip to content

Fix cross-reference slugs#646

Merged
cncastillo merged 1 commit into
masterfrom
fix-docs-slugs
Nov 18, 2025
Merged

Fix cross-reference slugs#646
cncastillo merged 1 commit into
masterfrom
fix-docs-slugs

Conversation

@cncastillo
Copy link
Copy Markdown
Member

Documenter 1.16 tightened its cross-reference checks, so links like [ADC](@ref) and [Phantom](@ref) started failing because multiple headings share the same slug. This patch points those references at their concrete definitions (KomaMRIBase.ADC, KomaMRIBase.Sequence, KomaMRIBase.Phantom), giving Documenter unique targets again and unblocking the docs build.

@cncastillo cncastillo merged commit 07e82d6 into master Nov 18, 2025
10 of 11 checks passed
@cncastillo cncastillo deleted the fix-docs-slugs branch November 18, 2025 06:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (9351546) to head (cf1ee75).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   90.00%   90.14%   +0.13%     
==========================================
  Files          57       57              
  Lines        3233     3228       -5     
==========================================
  Hits         2910     2910              
+ Misses        323      318       -5     
Flag Coverage Δ
base 89.08% <ø> (ø)
core 89.73% <ø> (+0.78%) ⬆️
files 94.05% <ø> (ø)
komamri 88.21% <ø> (ø)
plots 90.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant