Handle raw output for sequences without ADC#763
Open
cncastillo wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #763 +/- ##
==========================================
- Coverage 89.66% 88.70% -0.97%
==========================================
Files 74 74
Lines 5179 5180 +1
==========================================
- Hits 4644 4595 -49
- Misses 535 585 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
simulate(...; sim_params["return_type"] = "raw")failed for sequences without ADC samples because raw-data conversion tried to reduce an empty k-space trajectory andshowassumed at least one profile.Solution
Returns a header-only
RawAcquisitionDatawhen no ADC events are present and makesshowhandle empty profile lists.Tests
Pkg.test("KomaMRICore")Development
Closes #165