Reject negative ADC labels and default raw recon to custom#765
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 89.82% 88.57% -1.26%
==========================================
Files 76 76
Lines 5398 5399 +1
==========================================
- Hits 4849 4782 -67
- Misses 549 617 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
CI failed in the docs build because Verified locally with |
|
Follow-up: the tutorial now uses the intended Verified with |
Problem
Negative ADC labels fail late during raw-data conversion because ISMRMRD encoding counters are unsigned. For long simulations this means users only see the failure after simulation work has already completed.
The raw-data header also used
otheras the default trajectory label, while KomaMRI-generated raw data should usecustomfor reconstruction.Solution
get_labels(seq)at the start ofsimulateand stops on the first negative value.othertocustom.LabelSethack.Tests
Pkg.test("KomaMRICore")Development
Closes #637
Context: discussion #786