Skip to content

Allow docs preview comments on PRs#771

Merged
cncastillo merged 2 commits into
masterfrom
codex/fix-docs-preview-comment-permission
May 3, 2026
Merged

Allow docs preview comments on PRs#771
cncastillo merged 2 commits into
masterfrom
codex/fix-docs-preview-comment-permission

Conversation

@cncastillo
Copy link
Copy Markdown
Member

@cncastillo cncastillo commented May 3, 2026

Summary

  • give the Docs Preview workflow pull-requests: write so it can create/update PR comments
  • serialize docs deploy and docs preview cleanup with one gh-pages-deploy concurrency group

Root cause

The preview comment workflow found PR #769 and computed the preview URL, but GitHub rejected POST /issues/769/comments with 403 Resource not accessible by integration. The response advertised accepted permissions as issues=write; pull_requests=write; the workflow only had pull-requests: read.

The cleanup workflow can also push gh-pages while the normal Documentation job is still building, which causes git push ... HEAD:gh-pages to fail with fetch first. Both gh-pages writers now share the same concurrency group.

Testing

  • ruby -e 'require "yaml"; Dir[".github/workflows/*.yml"].each { |f| YAML.load_file(f) }; puts "yaml ok"'\n- git diff --check

@cncastillo cncastillo merged commit d3b13a1 into master May 3, 2026
12 checks passed
@cncastillo cncastillo deleted the codex/fix-docs-preview-comment-permission branch May 3, 2026 07:57
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.68%. Comparing base (87f621f) to head (e27f751).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
- Coverage   90.01%   88.68%   -1.34%     
==========================================
  Files          74       74              
  Lines        5179     5171       -8     
==========================================
- Hits         4662     4586      -76     
- Misses        517      585      +68     
Flag Coverage Δ
base 86.48% <ø> (ø)
core 80.47% <ø> (-10.17%) ⬇️
files 95.26% <ø> (ø)
komamri 88.23% <ø> (ø)
plots 90.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant