Skip to content

Harden docs preview workflows#772

Merged
cncastillo merged 1 commit into
masterfrom
codex/harden-docs-preview-actions
May 3, 2026
Merged

Harden docs preview workflows#772
cncastillo merged 1 commit into
masterfrom
codex/harden-docs-preview-actions

Conversation

@cncastillo
Copy link
Copy Markdown
Member

@cncastillo cncastillo commented May 3, 2026

Problem: the previous gh-pages concurrency lock was on the whole Documentation job. GitHub only keeps one pending job per concurrency group, so concurrent docs runs could cancel pending docs jobs instead of queueing them. The preview comment workflow also waited for the entire CI workflow to succeed, even though the relevant signal is the Documentation job.\n\nSolution: remove the broad docs/cleanup concurrency lock, and make the preview comment workflow check that the current PR head has a successful Documentation job before posting/updating the link.\n\nValidation: parsed the touched workflow YAML, ran git diff --check, and ran actionlint on CI.yml, docs-preview.yml, and docs-preview-cleanup.yml.

@cncastillo cncastillo added the documentation Improvements to docs., it also triggers doc preview label May 3, 2026
@cncastillo cncastillo force-pushed the codex/harden-docs-preview-actions branch from 3b34b7e to e1ae6f5 Compare May 3, 2026 08:15
@cncastillo cncastillo merged commit eff137f into master May 3, 2026
12 checks passed
@cncastillo cncastillo deleted the codex/harden-docs-preview-actions branch May 3, 2026 08:19
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.68%. Comparing base (d3b13a1) to head (e1ae6f5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   90.01%   88.68%   -1.34%     
==========================================
  Files          74       74              
  Lines        5179     5171       -8     
==========================================
- Hits         4662     4586      -76     
- Misses        517      585      +68     
Flag Coverage Δ
base 86.48% <ø> (ø)
core 80.47% <ø> (-10.17%) ⬇️
files 95.26% <ø> (ø)
komamri 88.23% <ø> (ø)
plots 90.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements to docs., it also triggers doc preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant