Skip to content

fix: optimize Rotate displacement! matrix operations (#604)#787

Merged
cncastillo merged 2 commits into
JuliaHealth:masterfrom
Mxyank24:fix-604-rotation
May 21, 2026
Merged

fix: optimize Rotate displacement! matrix operations (#604)#787
cncastillo merged 2 commits into
JuliaHealth:masterfrom
Mxyank24:fix-604-rotation

Conversation

@Mxyank24
Copy link
Copy Markdown
Contributor

Fixes #604

Refactored Rotate displacement functions to use loop fusion (@.) and deg2rad. This eliminates intermediate array allocations (e.g., x .- cx) in the hot loop, resolving the 10x slowdown.

@cncastillo cncastillo added the run-gpu-ci To run .buildkite CI label May 21, 2026
@cncastillo
Copy link
Copy Markdown
Member

Thank you so much! :) waiting for tests to pass and we will register a new version of KomaMRIBase.

@Mxyank24
Copy link
Copy Markdown
Contributor Author

Thank you so much! :) waiting for tests to pass and we will register a new version of KomaMRIBase.

My pleasure sir.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (fa76b7b) to head (c9a36e8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   89.83%   89.82%   -0.01%     
==========================================
  Files          76       76              
  Lines        5401     5398       -3     
==========================================
- Hits         4852     4849       -3     
  Misses        549      549              
Flag Coverage Δ
base 86.47% <100.00%> (-0.02%) ⬇️
core 89.65% <ø> (ø)
files 95.26% <ø> (ø)
komamri 88.32% <ø> (ø)
plots 90.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...MRIBase/src/motion/actions/simpleactions/Rotate.jl 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cncastillo cncastillo merged commit 230fbad into JuliaHealth:master May 21, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-gpu-ci To run .buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize Rotation motion

2 participants