Skip to content

(WIP) Phantom time dependent properties #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pvillacorta wants to merge 2 commits into
base: master
Choose a base branch
from

Extend variable rho to remaining Phantom properties. Corresponding te…

b1f95f6
Select commit
Loading
Failed to load commit list.
Draft

(WIP) Phantom time dependent properties #794

Extend variable rho to remaining Phantom properties. Corresponding te…
b1f95f6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 1, 2026 in 1s

88.20% (target 90.00%)

View this Pull Request on Codecov

88.20% (target 90.00%)

Details

Codecov Report

❌ Patch coverage is 81.85654% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.20%. Comparing base (33dab33) to head (b1f95f6).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
KomaMRIPlots/src/ui/DisplayFunctions.jl 75.51% 12 Missing ⚠️
...ase/src/datatypes/phantom/TimeDependentProperty.jl 64.51% 11 Missing ⚠️
KomaMRIBase/src/motion/SpinSpan.jl 0.00% 10 Missing ⚠️
...re/src/simulation/SimMethods/Bloch/gpu/BlochGPU.jl 0.00% 6 Missing ⚠️
KomaMRICore/src/simulation/Flow.jl 86.95% 3 Missing ⚠️
KomaMRIBase/src/datatypes/Phantom.jl 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   89.80%   88.20%   -1.61%     
==========================================
  Files          76       77       +1     
  Lines        5407     5544     +137     
==========================================
+ Hits         4856     4890      +34     
- Misses        551      654     +103
Files with missing lines Coverage Δ
KomaMRIBase/src/KomaMRIBase.jl 85.71% <ø> (ø)
KomaMRIBase/src/motion/MotionList.jl 100.00% <100.00%> (ø)
KomaMRIBase/src/motion/NoMotion.jl 96.00% <100.00%> (ø)
KomaMRIBase/src/timing/Interpolation.jl 96.00% <100.00%> (ø)
KomaMRIBase/src/timing/TimeCurve.jl 95.83% <ø> (ø)
KomaMRICore/src/simulation/Functors.jl 63.63% <ø> (-13.64%) ⬇️
...re/src/simulation/SimMethods/Bloch/cpu/BlochCPU.jl 100.00% <100.00%> (ø)
...e/src/simulation/SimMethods/BlochDict/BlochDict.jl 89.47% <100.00%> (+1.59%) ⬆️
...ation/SimMethods/BlochMagnus/cpu/BlochMagnusCPU.jl 100.00% <100.00%> (ø)
...c/simulation/SimMethods/BlochSimple/BlochSimple.jl 91.48% <100.00%> (+1.24%) ⬆️
... and 8 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov