Implement Pulseq-style sequence construction and export parity#804
Open
cncastillo wants to merge 13 commits into
Open
Implement Pulseq-style sequence construction and export parity#804cncastillo wants to merge 13 commits into
cncastillo wants to merge 13 commits into
Conversation
cncastillo
added
documentation
cncastillo
force-pushed
the
codex/pulse-designer-rework
branch
2 times, most recently
from
8929914 to
a49c1be
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
==========================================
- Coverage 90.06% 87.68% -2.39%
==========================================
Files 76 93 +17
Lines 5397 6067 +670
==========================================
+ Hits 4861 5320 +459
- Misses 536 747 +211
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cncastillo
force-pushed
the
codex/pulse-designer-rework
branch
2 times, most recently
from
fd8f0a4 to
2b2cc8c
Compare
cncastillo
force-pushed
the
codex/pulse-designer-rework
branch
from
2b2cc8c to
882fe9d
Compare
Contributor
|
Preview available: https://juliahealth.github.io/KomaMRI.jl/previews/PR804/ Last preview build: 5f305ec, Docs Preview run 27978770113 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements most Pulseq-style event constructors in
KomaMRIBase.PulseDesigner, adds Pulseq read/write parity handling, and introduces MATLAB Pulseq parity tests/CI.The new constructors return native Koma objects, so the same sequence can be plotted, simulated, checked, and exported to
.seq.Implemented Pulseq-style constructors
mr.makeTrapezoidmake_trapezoidbuild_trapezoidmr.makeExtendedTrapezoidmake_extended_trapezoidbuild_extended_trapezoidmr.makeExtendedTrapezoidAreamake_extended_trapezoid_areabuild_extended_trapezoid_areamr.makeArbitraryGradmake_arbitrary_gradbuild_arbitrary_gradmr.makeBlockPulsemake_block_pulsebuild_block_pulsemr.makeSincPulsemake_sinc_pulsebuild_sinc_pulsemr.makeGaussPulsemake_gauss_pulsebuild_gauss_pulsemr.makeArbitraryRfmake_arbitrary_rfbuild_arbitrary_rfmr.makeAdiabaticPulsemake_adiabatic_pulsebuild_adiabatic_pulsemr.makeAdcmake_adcbuild_adcmr.makeDelaymake_delaybuild_delaymr.makeLabelmake_labelbuild_labelmr.makeRotationmake_rotationbuild_rotationmr.makeTriggermake_triggerbuild_triggermr.makeDigitalOutputPulsemake_digital_output_pulsebuild_digital_output_pulseOther changes
area(...)and RF timing/frequency primitives used by PulseDesigner and Pulseq IO.write_seqtiming and hardware checks and the values used for those checks.plot_kspace(...; view_2d=true)and bumpsKomaMRIPlotsto0.11.1.KomaMRIBaseandKomaMRIFilesfor the new non-breaking functionality.Testing
Pkg.test("KomaMRIBase")Pkg.test("KomaMRIFiles")