Skip to content

[ChunkCodecCore] BREAKING change to the resizing behavior in try_resize_decode! #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented May 20, 2025

dst may now be longer than the returned number of bytes, even if dst was grown with resize!.

try_resize_decode! will now only grow dst, never shrink it.

If max_size is less than length(dst), instead of throwing an error, try_resize_decode! will now act as if max_size == length(dst).

Also added the grow_dst! helper function.

@nhz2 nhz2 changed the title [ChunkCodecCore] BREAKING the resizing behavior in try_resize_decode! changed [ChunkCodecCore] BREAKING change to the resizing behavior in try_resize_decode! May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (a348174) to head (9b6d723).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   96.04%   93.96%   -2.08%     
==========================================
  Files           4       33      +29     
  Lines         177     1343    +1166     
==========================================
+ Hits          170     1262    +1092     
- Misses          7       81      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nhz2 nhz2 marked this pull request as ready for review May 20, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant