-
Notifications
You must be signed in to change notification settings - Fork 80
Add support for GPX.jl #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 8 8
Lines 413 413
=======================================
Hits 314 314
Misses 99 99
Continue to review full report at Codecov.
|
|
As mentioned in s-celles/KMLTracks.jl#6 (comment) maybe we should only focus on GPX.jl first (with both load and save and also with tests as mentioned in s-celles/GPX.jl#5 (comment) |
|
Any magic bytes available? See my rant. |
|
Hey @timholy, GPX is an XML-based format which does not have magic bytes in the traditional sense. The XML namespace is the closest thing. See example. Perhaps there could be some content-aware file type detection mechanism which specializes for XML, but I feel it might end up being pretty fragile due to e.g. white space, file encoding, updated xmlns versions/URLs, etc. What are your thoughts? As @scls19fr mentioned we have a few more steps prior to taking this "prime time". |
This reverts commit a749812.
|
Sorry for the delay. I'm willing to merge this if you're still interested. |
|
No problem Tim :) I haven't used this for a little while, but this should still be good to merge. |
|
Thanks! |
|
Oh, GPX was never registered! I'm reverting #299. Sorry. |
This is pending registration of GPX.jl and KMLTracks.jl and the merging of https://github.com/scls19fr/GPX.jl/pull/