Skip to content

Conversation

@alhirzel
Copy link
Contributor

@alhirzel alhirzel commented Jun 29, 2020

This is pending registration of GPX.jl and KMLTracks.jl and the merging of https://github.com/scls19fr/GPX.jl/pull/

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files           8        8           
  Lines         413      413           
=======================================
  Hits          314      314           
  Misses         99       99           
Impacted Files Coverage Δ
src/registry.jl 92.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882dc75...1ed3e49. Read the comment docs.

@alhirzel alhirzel changed the title WIP: Add support for GPX.jl WIP: Add support for GPX.jl and KMLTracks.jl Jun 29, 2020
@s-celles
Copy link

As mentioned in s-celles/KMLTracks.jl#6 (comment) maybe we should only focus on GPX.jl first (with both load and save and also with tests as mentioned in s-celles/GPX.jl#5 (comment)

@timholy
Copy link
Member

timholy commented Jul 1, 2020

Any magic bytes available? See my rant.

@alhirzel
Copy link
Contributor Author

Hey @timholy, GPX is an XML-based format which does not have magic bytes in the traditional sense. The XML namespace is the closest thing. See example.

Perhaps there could be some content-aware file type detection mechanism which specializes for XML, but I feel it might end up being pretty fragile due to e.g. white space, file encoding, updated xmlns versions/URLs, etc. What are your thoughts? As @scls19fr mentioned we have a few more steps prior to taking this "prime time".

@alhirzel alhirzel changed the title WIP: Add support for GPX.jl and KMLTracks.jl WIP: Add support for GPX.jl Jul 15, 2020
@timholy
Copy link
Member

timholy commented Feb 24, 2021

Sorry for the delay. I'm willing to merge this if you're still interested.

@alhirzel alhirzel changed the title WIP: Add support for GPX.jl Add support for GPX.jl Mar 3, 2021
@alhirzel
Copy link
Contributor Author

alhirzel commented Mar 3, 2021

No problem Tim :) I haven't used this for a little while, but this should still be good to merge.

@timholy timholy mentioned this pull request Mar 3, 2021
@timholy timholy closed this in #299 Mar 3, 2021
@timholy
Copy link
Member

timholy commented Mar 3, 2021

Thanks!

@timholy
Copy link
Member

timholy commented Mar 3, 2021

Oh, GPX was never registered! I'm reverting #299. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants