-
Notifications
You must be signed in to change notification settings - Fork 142
CI: Update images, versions #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Turns out the |
|
This is ready for review and/or merging. The time-out is a slow multi-threaded test on 64-bit Windows for Julia 1.9 – the same test succeeds for 32-bit Windows and for all other Julia versions. |
|
This seems good. Should we tighten up the compat though? |
|
Do you want to stop testing with Julia 1.9, or declare that Julia 1.9 cannot be used? I think the tests still run reasonably fast and there is no reason to test fewer Julia versions. The slow tests are the Windows multi-threaded lock tests. I don't know why they are slow or timing out, maybe they are running out of memory and testing with a smaller array might help? |
To me these are not distinct steps. If we stop testing on 1.9, we should not declare compat with 1.9 because we do not know if that is true or not. I also do not think we need to support unsupported versions of Julia. If we have a reason to move the minimum compat to Julia 1.10 then we should without hesitation. |
|
Okay. I think there is no reason to move to 1.10 at the moment, but also no reason to stick with 1.9... |
No description provided.