add support for symbols as keys#130
Conversation
Pull Request Test Coverage Report for Build 7008504781
💛 - Coveralls |
|
Doc errors appear unrelated to this PR |
|
Thanks a lot for preparing this. I just looked at it and really like the idea to make the interface more DataFrame-like. I got carried away a bit and implemented dot syntax for subsetting as well so that you can use Could you have a look if this works for you? |
Pull Request Test Coverage Report for Build 7043631258
💛 - Coveralls |
Pull Request Test Coverage Report for Build 7113230225
💛 - Coveralls |
|
in the depths of AGU prep right now but will review this asap |
alex-s-gardner
left a comment
There was a problem hiding this comment.
This is fantastic!!! I took the changes for a quick spin and everything was intuitive and worked as expected. I see use of "z.metadata" which I think now needs to be removed and a "metadata()" function likely needs to be added.
| "Type" => "ZArray", | ||
| "Data type" => eltype(z), | ||
| "Shape" => size(z), | ||
| "Chunk Shape" => z.metadata.chunks, |
There was a problem hiding this comment.
does z.metadata.chunks need to be updated now that we have . inexing
There was a problem hiding this comment.
I don't think so. It is only ZGroups that have the new . indexing where we need to be careful, ZArrays would still behave the same
| "Data type" => eltype(z), | ||
| "Shape" => size(z), | ||
| "Chunk Shape" => z.metadata.chunks, | ||
| "Order" => z.metadata.order, |
There was a problem hiding this comment.
does z.metadata.order need to be updated now that we have . inexing
| "Order" => z.metadata.order, | ||
| "Read-Only" => !z.writeable, | ||
| "Read-Only" => !iswriteable(z), | ||
| "Compressor" => z.metadata.compressor, |
There was a problem hiding this comment.
same comment for all occurrences ofz.metadata
|
Adding a The simplest solution would be to replace all |
This adds support for symbol indexing into a ZGroup