Skip to content

Overload Base.UInt8 explicitly #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felixcremer
Copy link
Contributor

This would hopefully get rid of the following warning in julia 1.12

 ┌ Zarr
│  WARNING: Constructor for type "UInt8" was extended in `Zarr` without explicit qualification or import.
│    NOTE: Assumed "UInt8" refers to `Base.UInt8`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function UInt8 end`.
│    Hint: To silence the warning, qualify `UInt8` as `Base.UInt8` in the method signature or explicitly `import Base: UInt8`.

@mkitti
Copy link
Member

mkitti commented May 8, 2025

I slipped a commit like this into #182 , but yes, doing this independently is best.

@coveralls
Copy link

coveralls commented May 8, 2025

Pull Request Test Coverage Report for Build 14908265411

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 84.868%

Totals Coverage Status
Change from base Build 13680422725: -1.2%
Covered Lines: 903
Relevant Lines: 1064

💛 - Coveralls

@mkitti mkitti self-requested a review May 12, 2025 17:13
Copy link
Member

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants