Open
Conversation
This reduces the test diff
This also reduces the test diff
Change VersionedStore to FormattedStore
TODO: Fix Zarr v3 type strings
mkitti
force-pushed
the
mkitti-v3-prototype
branch
from
7051c32 to
d4217fb
Compare
Pull Request Test Coverage Report for Build 15430475317Details
💛 - Coveralls |
meggart
reviewed
Jun 12, 2025
|
|
||
| See Zarr version 2 | ||
| """ | ||
| struct FormattedStore{V,SEP,STORE <: AbstractStore} <: AbstractStore |
Collaborator
There was a problem hiding this comment.
Why is it necessary to have the separator as a type parameter? Could this simply be a struct field?
Member
Author
There was a problem hiding this comment.
I earlier had tried this approach.
The main question is how much conditional evaluation do you want to do with each call to citostring versus constant propagation.
The separator parameter is really a "chunk key encoding" parameter. There are currently six cases:
- Zarr v2,
'.'(default) - Zarr v2,
'/' - Zarr v3,
'.' - Zarr v3,
'/'(default) - Zarr v3, V2 chunk key encoding,
'.'(default) - Zarr v3, V2 chunk key encoding,
'/'
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a forward looking branch that builds on top of #182 to test what a Zarr v3 implementation might look like.
The initial goal is read and write valid Zarr v3 arrays that are similar conceptually to Zarr v2 arrays.