Skip to content

Conversation

@felixcremer
Copy link
Contributor

This makes size(zarr, dimnum= return 1 for to large dimensions numbers and give a better error message for negative dimension numbers.

This is needed so that concatenation of cubes backed by a Zarr array still work in DiskArrays after
JuliaIO/DiskArrays.jl#280

@coveralls
Copy link

coveralls commented Oct 29, 2025

Pull Request Test Coverage Report for Build 19540979232

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 89.348%

Files with Coverage Reduction New Missed Lines %
src/metadata.jl 1 92.05%
Totals Coverage Status
Change from base Build 18793430184: 0.06%
Covered Lines: 973
Relevant Lines: 1089

💛 - Coveralls

@felixcremer
Copy link
Contributor Author

The nightly failures are an unrelated Pkg loading of precompiled packages problem and the codecov check is just strange. Because on codecov itself it looks as if all lines are hit.

Copy link
Member

@nhz2 nhz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though a more basic error message without string interpolation might slightly improve performance.

@meggart meggart merged commit 4544c28 into JuliaIO:master Nov 20, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants