Support Apple Silicon and enable screen capture#19
Merged
JamesWrigley merged 6 commits intoJun 2, 2026
Conversation
JamesWrigley
requested changes
May 19, 2026
Member
JamesWrigley
left a comment
There was a problem hiding this comment.
This should get a changelog entry too.
Member
|
Sorry forgot to mention, could you add a wee test too? |
Contributor
Author
|
tests fail because they need JuliaImGui/CImGui.jl#198 |
JamesWrigley
requested changes
May 30, 2026
Contributor
Author
|
works on my end (with unreleased but merged cimgui.jl version) |
JamesWrigley
approved these changes
Jun 1, 2026
Member
JamesWrigley
left a comment
There was a problem hiding this comment.
LGTM! Maybe try CI with CImGui v8 before merging?
42df167 to
f8b0f50
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 24.48% 26.14% +1.65%
==========================================
Files 5 5
Lines 927 960 +33
==========================================
+ Hits 227 251 +24
- Misses 700 709 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on JuliaImGui/CImGui.jl#198.