Skip to content

Support Apple Silicon and enable screen capture#19

Merged
JamesWrigley merged 6 commits into
JuliaImGui:masterfrom
aplavin:aarch64-darwin-static-cfunc
Jun 2, 2026
Merged

Support Apple Silicon and enable screen capture#19
JamesWrigley merged 6 commits into
JuliaImGui:masterfrom
aplavin:aarch64-darwin-static-cfunc

Conversation

@aplavin
Copy link
Copy Markdown
Contributor

@aplavin aplavin commented May 19, 2026

Copy link
Copy Markdown
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get a changelog entry too.

Comment thread src/engine.jl
Comment thread src/engine.jl Outdated
Comment thread src/wrapper.jl Outdated
@JamesWrigley
Copy link
Copy Markdown
Member

Sorry forgot to mention, could you add a wee test too?

@aplavin
Copy link
Copy Markdown
Contributor Author

aplavin commented May 19, 2026

tests fail because they need JuliaImGui/CImGui.jl#198

Comment thread src/engine.jl Outdated
Comment thread src/engine.jl Outdated
@aplavin
Copy link
Copy Markdown
Contributor Author

aplavin commented Jun 1, 2026

works on my end (with unreleased but merged cimgui.jl version)

Copy link
Copy Markdown
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe try CI with CImGui v8 before merging?

@aplavin aplavin force-pushed the aarch64-darwin-static-cfunc branch from 42df167 to f8b0f50 Compare June 1, 2026 12:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.14%. Comparing base (72ec1b0) to head (d57936b).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/engine.jl 77.27% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   24.48%   26.14%   +1.65%     
==========================================
  Files           5        5              
  Lines         927      960      +33     
==========================================
+ Hits          227      251      +24     
- Misses        700      709       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JamesWrigley JamesWrigley merged commit a298c85 into JuliaImGui:master Jun 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants