Skip to content

Bump min Julia to 1.10#21

Merged
JamesWrigley merged 1 commit into
JuliaImGui:masterfrom
aplavin:ci-bump-min-julia-1.10
May 30, 2026
Merged

Bump min Julia to 1.10#21
JamesWrigley merged 1 commit into
JuliaImGui:masterfrom
aplavin:ci-bump-min-julia-1.10

Conversation

@aplavin
Copy link
Copy Markdown
Contributor

@aplavin aplavin commented May 20, 2026

CImGui 7 requires Julia 1.10.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.48%. Comparing base (546792c) to head (934a977).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   24.04%   24.48%   +0.43%     
==========================================
  Files           5        5              
  Lines         919      927       +8     
==========================================
+ Hits          221      227       +6     
- Misses        698      700       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aplavin
Copy link
Copy Markdown
Contributor Author

aplavin commented May 29, 2026

anything else needed for this to be merged?

@JamesWrigley
Copy link
Copy Markdown
Member

JamesWrigley commented May 30, 2026

Nope, it's just that my usual workflow is to let people with commit access merge the PRs themselves once approved :) Not always necessary, but in my PRs I often have fixup commits or other things that would benefit from a rebase after approving but before merging.

@JamesWrigley JamesWrigley merged commit 72ec1b0 into JuliaImGui:master May 30, 2026
6 checks passed
@aplavin
Copy link
Copy Markdown
Contributor Author

aplavin commented May 30, 2026

Hmm, I'm not sure how exactly it works, but doesn't seem like I have commit access to these repos?..
image

@JamesWrigley
Copy link
Copy Markdown
Member

Ah sorry, it seems that the organization settings only gave read privs by default to members. Changed it to give write access now so you should be able to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants