Route unknown legacy string keys on ImageViewGUI to extras#325
Merged
Conversation
Pre-0.13 code used the GUI `Dict` as scratch space for arbitrary keys
(e.g. stashing a `zoom_region` observable). The 0.13 shim was strict and
threw `ArgumentError` on unknown keys, which broke downstream packages
that did this. Route unknown keys through the `extras::Dict{Symbol,Any}`
field instead, preserving the scratch-space pattern through the
deprecation cycle. Also define `Base.haskey(::ImageViewGUI, ::AbstractString)`.
Mark `ImageDisplay`, `ImageViewGUI`, and `ImageROI` public so downstream
packages can dispatch on them without tripping ExplicitImports.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-0.13 code used the GUI
Dictas scratch space for arbitrary keys (e.g. stashing azoom_regionobservable). The 0.13 shim was strict and threwArgumentErroron unknown keys, which broke downstream packages that did this. Route unknown keys through theextras::Dict{Symbol,Any}field instead, preserving the scratch-space pattern through the deprecation cycle. Also defineBase.haskey(::ImageViewGUI, ::AbstractString).Mark
ImageDisplay,ImageViewGUI, andImageROIpublic so downstream packages can dispatch on them without tripping ExplicitImports.