gen: remove stale jl_cxx_files duplicate of src/#88
Merged
Conversation
These eight .jl files (Mat, Vec, OpenCV, cv_cxx, cv_manual_wrap, mat_conversion, types_conversion, typestructs) were inherited from opencv_contrib/modules/julia/jl_cxx_files/, where they used to be shipped inside OpenCV_jll. Since the move to per-repo Julia sources under src/, the package loads only from src/ and Yggdrasil ships only libopencv_julia.* (build_tarballs.jl drops the staged Julia tree), so this directory's contents were never read at runtime and had drifted from src/. regenerate.jl only copies *wrap.jl from autogen_jl/ into src/generated/, so removing it has no effect on that pipeline. The Yggdrasil-side CMake copy line is dropped in the same change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen/jl_cxx_files/(8.jlfiles inherited fromopencv_contrib/modules/julia/jl_cxx_files/) and thefile(COPY ... jl_cxx_files/ ...)line ingen/CMakeLists.txt.OpenCV_jll; since the move to in-repo Julia sources undersrc/, OpenCV.jl loads only fromsrc/and the JLL ships onlylibopencv_julia.*(Yggdrasil'sbuild_tarballs.jldiscards the staged Julia tree). The directory was unread at runtime and had drifted fromsrc/.regenerate.jlonly copies*wrap.jlfromautogen_jl/intosrc/generated/, so this is a no-op for the generator pipeline. The Yggdrasil-sidegen/CMakeLists.txtchange is similarly a no-op for the resultinglibopencv_julia.*.Test plan
git diff --exit-codeonsrc/generated/)O/OpenCV/build_tarballs.jland confirm the resultinglibopencv_julia.*is byte-identical to a build from the prior pin (sanity check that the dropped CMake copy line affects only discarded staging output)🤖 Generated with Claude Code