throw an error instead of falling back to getfield
for Ptr
types
#542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The generated
Base.getproperty(x::Ptr{T}, f::Symbol)
emits agetfield(x,f)
if all other cases are exhausted.But
getfield
is not really defined forPtr
(which makes sense, since it doesn't have any field) and static analysis tools likeJET
generate a lot of noise about it.What about throwing an exception instead? It shouldn't be breaking since we'd be throwing an exception anyway, and provides a better error message and makes analysis tools happy.