Add unify keyword and default if to true#64
Add unify keyword and default if to true#64Suavesito-Olimpiada wants to merge 1 commit intoJuliaIntervals:masterfrom
unify keyword and default if to true#64Conversation
|
Still to add tests and discuss the proper algorithm to unify boxes. |
|
Out of curiosity, do you know how much computational overhead this introduces? Just wondering which one would be a better default value. Here a simple MWE that might be good for benchmarking this example should return 2990 minimisers, so it might be a good small but not too small example for benchmarking |
|
Ah, you answered my questions while I was writing that 😄 Amazing! sorry for the noise |
|
Don't worry, happy to help. :D |
|
At a first glance this looks great, thanks! Could you please add some tests? |
|
Sure, I'll add test. I just want to know what do you think about the "problem" of using union-find that I described in the comment in the original issue. |
| return disjoint_sets[i] | ||
| end | ||
|
|
||
| function add_set!(disjoint_sets, weights_sets, i, j) |
There was a problem hiding this comment.
Is an optimizations for union-find to make the union and find operations almost constant.
There was a problem hiding this comment.
This is the fastest asymtotically variant known of union-find. The algorithm is described here.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 91.83% 92.12% +0.28%
==========================================
Files 5 6 +1
Lines 98 127 +29
==========================================
+ Hits 90 117 +27
- Misses 8 10 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix #48